From adeff52f89aefc2291252baf4370010364303051 Mon Sep 17 00:00:00 2001 From: Harshil Patel Date: Tue, 2 Nov 2021 10:37:53 +0000 Subject: [PATCH 1/2] Change params.hostnames from map to string --- README.md | 6 ------ nfcore_custom.config | 21 +++------------------ 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index 6c0d197..293a9c9 100644 --- a/README.md +++ b/README.md @@ -66,12 +66,6 @@ See [`nf-core/configs`](https://github.com/nf-core/configs/tree/master/conf) for Please also make sure to add an extra `params` section with `params.config_profile_description`, `params.config_profile_contact` and `params.config_profile_url` set to reasonable values. Users will get information on who wrote the configuration profile then when executing a nf-core pipeline and can report back if there are things missing for example. -### Checking user hostnames - -If your cluster has a set of consistent hostnames, nf-core pipelines can check that users are using your profile. -Add one or more hostname substrings to `params.hostnames` under a key that matches the profile name. -If the user's hostname contains this string at the start of a run or when a run fails and their profile does not contain the profile name, a warning message will be printed. - ### Testing If you want to add a new custom config file to `nf-core/configs` please test that your pipeline of choice runs as expected by using the [`-c`](https://www.nextflow.io/docs/latest/config.html) parameter. diff --git a/nfcore_custom.config b/nfcore_custom.config index eb5b509..2aba7fa 100644 --- a/nfcore_custom.config +++ b/nfcore_custom.config @@ -61,23 +61,8 @@ profiles { uzh { includeConfig "${params.custom_config_base}/conf/uzh.config" } } -// If user hostnames contain one of these substring and they are -// not running the associated profile, it will trigger a warning message -// Should be defined here for all profiles (not within profile config) params { - // This is a groovy map, not a nextflow parameter set - hostnames = [ - binac: ['.binac.uni-tuebingen.de'], - cbe: ['.cbe.vbc.ac.at'], - cfc: ['.hpc.uni-tuebingen.de'], - crick: ['.thecrick.org'], - genotoul: ['.genologin1.toulouse.inra.fr', '.genologin2.toulouse.inra.fr'], - genouest: ['.genouest.org'], - icr_davros: ['.davros.compute.estate'], - imperial: ['.hpc.ic.ac.uk'], - imperial_mb: ['.hpc.ic.ac.uk'], - uppmax: ['.uppmax.uu.se'], - utd_ganymede: ['ganymede.utdallas.edu'], - utd_sysbio: ['sysbio.utdallas.edu'] - ] + // Changed from a Groovy Map to a string for backwards compatibility + // See https://github.com/nf-core/tools/issues/1304 + hostnames = '' } From 7aff8923ea0d5719b7c8988a677449e0355444f1 Mon Sep 17 00:00:00 2001 From: Harshil Patel Date: Tue, 2 Nov 2021 10:52:14 +0000 Subject: [PATCH 2/2] Test remove params.hostnames entirely --- nfcore_custom.config | 6 ------ 1 file changed, 6 deletions(-) diff --git a/nfcore_custom.config b/nfcore_custom.config index 2aba7fa..b1047b8 100644 --- a/nfcore_custom.config +++ b/nfcore_custom.config @@ -60,9 +60,3 @@ profiles { utd_sysbio { includeConfig "${params.custom_config_base}/conf/utd_sysbio.config" } uzh { includeConfig "${params.custom_config_base}/conf/uzh.config" } } - -params { - // Changed from a Groovy Map to a string for backwards compatibility - // See https://github.com/nf-core/tools/issues/1304 - hostnames = '' -}