millironx/nf-core_modules
1
0
Fork 0
mirror of https://github.com/MillironX/nf-core_modules.git synced 2024-11-10 20:23:10 +00:00
Code Issues Releases Packages Activity

Fix DeepARG depenency issue with singularity containers (#1397)

Browse source 
* fix: remove left-over unnecessary code

* Adds --fakeroot option for singularity usage with DeepARG as workaround for broken conda dependency

* Update modules/deeparg/downloaddata/main.nf

Co-authored-by: Moritz E. Beber <midnighter@posteo.net>

* Update modules/deeparg/predict/main.nf

Co-authored-by: Moritz E. Beber <midnighter@posteo.net>

* Apply suggestions from code review

* Update main.nf

* Update main.nf

* Update main.nf

* Update main.nf

* Go back to original logic

Co-authored-by: Moritz E. Beber <midnighter@posteo.net>
This commit is contained in:
James A. Fellows Yates 2022-03-17 13:08:51 +01:00 committed by GitHub
parent df60a58426
commit f469045a95
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
modules/deeparg/downloaddata/main.nf
View file

@ -7,6 +7,12 @@ process DEEPARG_DOWNLOADDATA {
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity/deeparg:1.0.2--pyhdfd78af_1' : 'https://depot.galaxyproject.org/singularity/deeparg:1.0.2--pyhdfd78af_1' :
'quay.io/biocontainers/deeparg:1.0.2--pyhdfd78af_1' }" 'quay.io/biocontainers/deeparg:1.0.2--pyhdfd78af_1' }"
/*
We have to force singularity to run with --fakeroot to allow reading of a problematic file with borked read-write permissions in an upstream dependency (theanos).
This flag may not be available on all systems and may be considered a security problem. so please document and /or warn for this in your pipeline!
*/
containerOptions { "${workflow.containerEngine}" == 'singularity' ? '--fakeroot' : '' }
input: input:

5
modules/deeparg/predict/main.nf
View file

@ -8,6 +8,11 @@ process DEEPARG_PREDICT {
container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ? container "${ workflow.containerEngine == 'singularity' && !task.ext.singularity_pull_docker_container ?
'https://depot.galaxyproject.org/singularity//deeparg:1.0.2--pyhdfd78af_1' : 'https://depot.galaxyproject.org/singularity//deeparg:1.0.2--pyhdfd78af_1' :
'quay.io/biocontainers/deeparg:1.0.2--pyhdfd78af_1' }" 'quay.io/biocontainers/deeparg:1.0.2--pyhdfd78af_1' }"
/*
We have to force singularity to run with --fakeroot to allow reading of a problematic file with borked read-write permissions in an upstream dependency (theanos).
This flag may not be available on all systems and may be considered a security problem. so please document and /or warn for this in your pipeline!
*/
containerOptions { "${workflow.containerEngine}" == 'singularity' ? '--fakeroot' : '' }
input: input:
tuple val(meta), path(fasta), val(model) tuple val(meta), path(fasta), val(model)