Commit graph

10 commits

Author SHA1 Message Date
Mahesh Binzer-Panchal
f8bd7902d9 Update Git SHA messagre 2022-06-10 11:01:40 +00:00
Mahesh Binzer-Panchal
25c742dc69 Commit suggestions from code review 2022-06-10 10:56:56 +00:00
Mahesh Binzer-Panchal
6a1cbce0f5
Update tests/test_versions_yml.py
Co-authored-by: Fabian Egli <fabianegli@users.noreply.github.com>
2022-06-10 12:54:08 +02:00
Mahesh Binzer-Panchal
0479544e02 Allow Git commit SHA's as version numbers 2022-06-10 09:46:14 +00:00
Chris Cheshire
f3a405e4f2
Fix for version file output check when performing an expected error test (#1242)
* hifiasm copied from fastqc

* hifiasm tests init from fastqc

* meta.yml init; test.yml and main.nf for printing version

* Add hifiasm version printing

* Removed spaced on an empty line

* Reverted hifiasm from main

* Ignores version file checking if testing for error

* Added comment

Co-authored-by: Sviatoslav Sidorov <sviatoslav.sidorov@crick.ac.uk>
Co-authored-by: Svyatoslav Sidorov <svet.sidorov@gmail.com>
Co-authored-by: Tamara Hodgetts <hodgett@crick.ac.uk>
2022-01-28 10:32:36 +01:00
Edmund Miller
c19671dca9
Subworkflow Infrastructure (#662)
* feat(subworkflows): Add align_bowtie2 subworkflow

For testing CI setup

* test(align_bowtie2): Add initial list of changes to test

* test(align_bowtie2): Add initial test

* refactor: Use tags to run subworkflows ci

For every underlying module used by workflow and allow the modules
pytest-modules definition be the source of truth.

* refactor: Use individual directories for subworkflows

* docs(align_bowtie2): Add initial meta.yml

Copied most of it from the bowtie2/align module.

* fix(align_bowtie2): Fix module include paths

* test(bam_sort_samtools): Add initial test

* ci(bam_sort_samtools): Add modules that trigger the tag

* test(bam_stats_samtools): Add initial test

* ci(bam_stats_samtools): Add keys to pick up changes

* docs(bam_samtools): Add initial meta.yml

* test(align_bowtie2): Fix path to subworkflow

* test(align_bowtie2): Update entry point

* fix(bam_sort_samtools): Update include paths

* test(bam_sort_samtools): Fix path

* style: Clean up addParams

* test(samtools_sort): Add suffix for test

* test(align_bowtie2): Add samtools_options for suffix

* test(bam_stats_samtools): Update path

* test(bam_stats_samtools): Use stats input

Otherwise it's just an example of how it's used in the bam_sort_samtools subworkflow

* ci(linting): Skip module linting of subworkflows

* ci(linting): Clean up startsWith statement

* test(bam_stats_samtools): Use single end test data for single end test

* test(bam_stats_samtools): Add expected files

* test(align_bowtie2): Add paired-end test

* test(align_bowtie2): Sort order of output

* test(align_bowtie2): Update hashes

* docs(align_bowtie2): Fix typo

* test(align_bowtie2): Update samtools output names

* test(align_bowtie2): Remove md5sums for bam/bai

* feat(subworkflows): Add nextflow.configs

These can be used for default settings in the future. They can then be
included in the conf/modules.config so that the params don't have to be
duplicated in the root nextflow.config.

* docs(subworkflows): Include modules instead of tools

* fix: Update to versions

* chore(align_bowtie2): Remove duplicate tag

* style: Format yamls

* test(subworkflows): Only check versions for modules

* chore: Update subworkflows to match rnaseq dev

* fix(subworkflows): Update paths

* fix(bam_sort_samtools): Fix sort parameters for testing

* Apply suggestions from code review

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* docs: Update TODOs with a message

* ci: Try using a matrix for strategy

* ci: Try passing an array

* Revert "ci: Try passing an array"

This reverts commit d3611fcd8332bbb9a8501e8dd299d0a623aaecaa.

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
2021-10-08 16:02:42 +01:00
Jose Espinosa-Carrasco
84f2302920
Correct parsing versions with trailing zeros (#795)
* Correct parsing versions with trailing zeros

* Fix test

* Update modules/custom/dumpsoftwareversions/main.nf

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>

* Fix tests and go back to output versions.yml

* Update tests/test_versions_yml.py to use BaseLoader

Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Gregor Sturm <mail@gregor-sturm.de>
2021-10-06 08:16:36 +02:00
Gregor Sturm
512f5dfc27
Better error message for FileNotFoundErrors (#755)
* Better error message for FileNotFoundErrors

* Update tests/test_versions_yml.py

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>

* Update test_versions_yml.py

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
2021-09-28 16:51:35 +02:00
Gregor Sturm
d73a988ff7
Cover case when processes have been imported under different name (#744)
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
2021-09-27 09:40:50 +01:00
Gregor Sturm
ab67a1d41b
Update fastqc to produce multi-version versions.yml (#665)
* Update fastqc to produce multi-version versions.yml

* Update readme and pull request template

* Fix markdownlint

* remove  variable

* Change publish dir to lowercase

* Re-add getSoftwareName

* Add custom pytest-workflow test to ensure versions.yml is valid

* Add docstring

* Remove __init__.py as it is not needed

* Remove changes to README, since this part went to nf-co.re

* Add NF_CORE_TEST env var

* Fix editorconfig

* Add additional consistency checks for versions.yml

* Update multiqc module

* Fix output channel
2021-09-24 10:01:54 +01:00