1
0
Fork 0
mirror of https://github.com/MillironX/taxprofiler.git synced 2024-11-23 11:29:54 +00:00

Apply suggestions from code review

Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
This commit is contained in:
Moritz E. Beber 2023-04-22 21:18:58 +02:00 committed by GitHub
parent 49086d9475
commit 08f06b9982
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions

View file

@ -7,7 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### `Added` ### `Added`
- [#276](https://github.com/nf-core/taxprofiler/pull/276) Implemented batching in the KrakenUniq samples processing. - [#276](https://github.com/nf-core/taxprofiler/pull/276) Implemented batching in the KrakenUniq samples processing. (added by @Midnighter)
- [#272](https://github.com/nf-core/taxprofiler/pull/272) - Add saving of final 'analysis-ready-reads' to dedicated directory. (❤️ to @alexhbnr for reporting, added by @jfy133) - [#272](https://github.com/nf-core/taxprofiler/pull/272) - Add saving of final 'analysis-ready-reads' to dedicated directory. (❤️ to @alexhbnr for reporting, added by @jfy133)
### `Fixed` ### `Fixed`

View file

@ -436,8 +436,8 @@
"type": "integer", "type": "integer",
"default": 20, "default": 20,
"fa_icon": "far fa-window-restore", "fa_icon": "far fa-window-restore",
"description": "Set the batch size for KrakenUniq", "description": "Specify the number samples for each KrakenUniq run",
"help_text": "Specify the batch size for KrakenUniq. The reference database for KrakenUniq is loaded into memory once in a process and then used to classify many samples. This parameter determines for how many samples at a time." "help_text": "Specify the batch size for KrakenUniq. The reference database for KrakenUniq is loaded into memory once in a process and then used to classify many samples. When you have many samples, a single KrakenUniq run can be rather slow. Alternatively, we can split up KrakenUniq runs for a 'batch' of samples, allowing a balance between shared using a database for multiple samples, but also faster parallelised KrakenUniq runs. This parameter determines for how many samples at a time."
}, },
"run_bracken": { "run_bracken": {
"type": "boolean", "type": "boolean",