when using the suffix option in the fastqc module it gets added with a "." to the ${meta.id}, this leads to sample name clashing when passing the fastqc output of raw and processed files suffixed with "trim" or "clean" to multiqc.
I suggest to remove the "." this would also be more consistent with the prefix def in most of the other nf-core modules.
##' Ref:
https://nfcore.slack.com/archives/CJRH30T6V/p1625129138043900
* add software/pairtools
* create a branch for pairtools/select
* fix the different output of conda and docker.
* rmove the md5sum for gzip files.
* Update software/pairtools/select/main.nf
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* update test file and documentation.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* Update salmon/quant to provide '--libType A' option
* Modify lib_type description to be a string
* Update tests
* lyb_type can be explicitly overwrite
* Update main.nf
* Update main.nf
* Update main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Update LAST to version 1238.
* Update functions.nf to the latest devel version.
* Update test MD5sums after updating software version.
* Make portable on MacOS
* Allow input alignments to be uncompressed.
While the strategy in this family of modules is to make all inputs and
outputs compressed, this change might be useful to some users.
As of LAST 2138, `last/split` does not allow its input to be compressed.
* Search for .des file, that is guaranteed to be unique.
Some LAST indexes have more than one .bck file and it makes the name
detection crash.
In this commit, I also standardise how the names are detected.
* Use value input channel and optional output channels to handle formats.
As discussed on Slack, it is preferred to use a value input channel
instead of sneaking options through `params.args2` or `params.format`
as we did.
Likewise, optional output channels with clearly labeled format are
preferred to 'catch-all' wildcards.
* Update test data names.
Closes: #459
Thanks: @FriederikeHanssen
(`samtools` tests are already fixed by another commit)
* Fix file names in tests.
The update of test data name required changes in the test yml files.
I also updated the `bismark/summary/main.nf` file to get its data
from the `params.test_data` map.
* hifiasm copied from fastqc
* hifiasm tests init from fastqc
* meta.yml init; test.yml and main.nf for printing version
* Add hifiasm version printing
* Removed spaced on an empty line
* Reverted hifiasm from main
* hifiasm copied from fastqc
* hifiasm tests init from fastqc
* meta.yml init; test.yml and main.nf for printing version
* Add hifiasm version printing
* Removed spaced on an empty line
* Reverted hifiasm from main
* Added seqtk/subseq and checking for seed in seqtk/sample
* Separate authors in software/seqtk/sample/meta.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Align commans in output channesl software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Define prefix in software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Use prefix in output file name software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Define suffix in options in tests/software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Change output file name in tests/software/seqtk/subseq/test.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Remove a to-do point from tests/software/seqtk/subseq/test.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Added --no-name into gzip commands
* Update samtools from 1.10 to 1.12 (#530)
* feat: remove social preview image to use GitHub OpenGraph
* feat: update samtools from 1.10 to 1.12
* fix: CI tests
* fix: add meta.yml file for samtools/merge
* Update software/samtools/merge/meta.yml
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* Update software/samtools/merge/meta.yml
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* hifiasm copied from fastqc
* hifiasm tests init from fastqc
* meta.yml init; test.yml and main.nf for printing version
* Add hifiasm version printing
* Removed spaced on an empty line
* Reverted hifiasm from main
* Added seqtk/subseq and checking for seed in seqtk/sample
* hifiasm copied from fastqc
* hifiasm tests init from fastqc
* meta.yml init; test.yml and main.nf for printing version
* Add hifiasm version printing
* Removed spaced on an empty line
* Reverted hifiasm from main
* Separate authors in software/seqtk/sample/meta.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Align commans in output channesl software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Define prefix in software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Use prefix in output file name software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Define suffix in options in tests/software/seqtk/subseq/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Change output file name in tests/software/seqtk/subseq/test.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Remove a to-do point from tests/software/seqtk/subseq/test.yml
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Added --no-name into gzip commands
* Replaced functions.nf in seqtk/subseq
* Refreshed tests for sample and subseq
* Corrected paired-end test and YAML description for sample
Co-authored-by: Sviatoslav Sidorov <sviatoslav.sidorov@crick.ac.uk>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Maxime U. Garcia <max.u.garcia@gmail.com>
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* add software/pairtools
* create a branch for pairtools/restrict
* fix the different output of conda and docker
* remove customized code.
* add newline to Frag.bed file.
* change the folder of frag.bed.
* change \n to \r\n
* Remove work.frag.bed
Co-authored-by: JoseEspinosa <kadomu@gmail.com>
* New last/mafconvert module to convert MAF alignments.
The `maf-convert` tool distributed with [LAST](https://gitlab.com/mcfrith/last)
reads alignmnts in [MAF](https://genome-asia.ucsc.edu/FAQ/FAQformat.html#format5)
format and converts them in another format (axt, blast, blasttab, chain,
gff, html, psl, sam, tab).
This new module is part of the work described in Issue #464. During this
development, we fix the versiob of LAST to 1219 to ensure consistency.
We will upgrade it later.
* Delete white space.
* Update the function.nf file to the dev version.
The `last-postmask` tool distributed with [LAST](https://gitlab.com/mcfrith/last)
filters alignments in a MAF file to remove those with too many masked
(lower-case) positions compared with their score.
As other filter modules like `last/split`, its output file risks to
overwrite its input file as their names are constructed from the sample
ID when multiple filters are chained in the pipeline. I added a check
that gives a clearer error message in this case. Please let me know
what you think about; I can add this test to the existing LAST modules
as well.
This new module is part of the work discribed in Issue #464. During this
development, we fix the version of LAST to 1219 to ensure consistency.
We will upgrade it later.
* New last/dotplot module for pairwise similarity plots
The `last-dotplot` tool takes a pairwise alignment in
[MAF](http://genome.ucsc.edu/FAQ/FAQformat.html#format5) format,
possibly compressed with gzip, or in a tabular format produced by the
`maf-convert` tool, and produces a similarity dot-plot of the two
sequences in one of the graphical formats supported by the Python
Imaging Library.
A the tool guesses the output format by the file extension of the file,
which is constructed by the module at run time, I have used the `args2`
option to convey this information to the module.
This new module is part of the work described in Issue #464. During
this development, we fix the version of LAST to 1219 to ensure
consistency (hence please ignore lint's version warning).
* Update the functions.nf file to the dev branch.
https://raw.githubusercontent.com/nf-core/tools/dev/nf_core/module-template/software/functions.nf
* feat: remove social preview image to use GitHub OpenGraph
* feat: update samtools from 1.10 to 1.12
* fix: CI tests
* fix: add meta.yml file for samtools/merge
* Update software/samtools/merge/meta.yml
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* Update software/samtools/merge/meta.yml
Co-authored-by: Jose Espinosa-Carrasco <kadomu@gmail.com>
* add software/pairtools
* create a branch for pairtools/sort
* fix the different output of conda and docker.
* remove customized code.
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* add software/pairtools
* create a branch for pairtools/parse
* fix the issue of bioconda output is different from docker.
* remove customized code from test.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* add software/pairtools
* create a branch for pairtools/flip
* fix the issue of PG line in output
* remove custom code from test.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* New last/lastal to align query sequences on a target index
`lastal` is the main program of the [LAST](https://gitlab.com/mcfrith/last)
suite. It align query DNA sequences in FASTA or FASTQ format to a
target index of DNA or protein sequences. The index is produced by
the `lastdb` program (module `last/lastdb`). The score matrix for
evaluating the alignment can be chosen among preset ones or computed
iteratively by the `last-train` program (module `last/train`). For
this reason, the `last/lastal` module proposed here has one input
channel containing an optional file, that has to be dummy when not used.
The LAST aligner outputs MAF files that can be very large (up to
hundreds of gigabytes), therefore this module unconditionally compresses
its output with gzip.
This new module is part of the work described in Issue #464. During
this development, we fix the version of LAST to 1219 to ensure
consistency (hence ignore lint's version warning).
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Un-hardcode the path to the LAST index.
Among multiple alternatives I have chosen the following command to
detect the sample name of the index, because it fails in situations
where there is no index files in the index folder, and in situations
were there are two indexes files in the folder. Not failing would
result in feeding garbage information in the INDEX_NAME variable.
basename \$(ls $index/*.bck) .bck
In case of missing file, a clear error message is given by `ls`. In
case of more than one file, the error message of `basename` is more
cryptic, unfortunately. (`basename: extra operand ‘.bck’`)
Alternatives that do not fail if there is no .bck file:
basename $index/*bck .bck
find $index -name '*bck' | sed 's/.bck//'
Alternatives that do not fail if there are more than one .bck file:
basename -s .bck $index/*bck
ls $index/*.bck | xargs basename -s .bck
find $index -name '*bck' | sed 's/.bck//'
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* New last/split module to find split alignments.
The `last-split` tool distributed with [LAST](https://gitlab.com/mcfrith/last)
finds split or spliced alignments in a MAF file that is produced with, for
example, LAST `lastal` command.
This new module is part of the work discribed in Issue #464. During this
development, we fix the versiob of LAST to 1219 to ensure consistency. We will
upgrade it later.
* Update software/last/split/main.nf
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* add additional ucsc tools
* Update software/ucsc/wigtobigwig/meta.yml
Co-authored-by: Kevin Menden <kevin.menden@live.com>
* Update the functions.nf and software name for ucsc/wigtobigwig and bigwigaverageoverbed.
Co-authored-by: Kevin Menden <kevin.menden@live.com>
* New module last/mafswap to reorder sequences in alignments
The `maf-swap` tool distributed with [LAST](https://gitlab.com/mcfrith/last)
reorders sequences in alignment files in Multiple Alignment Format.
When run without command-line arguments, it will swap the target and the
query sequences. This is useful when turning a many-to-many alignment
into a many-to-one and then a one-to-one alignment in conjunction with
the `last-split` command (split, swap, split and swap again).
The LAST aligner outputs MAF files, but other tools also use this
format. As MAF files can be very large (up to hundreds of gigabytes),
the module expects its input to be compressed with gzip and will
compress its output.
This new module is part of the work described in Issue #464. During
this development, we fix the version of LAST to 1219 to ensure
consistency (hence ignore lint's version warning).
* Update MD5 sum.
Actually, 7029066c27ac6f5ef18d660d5741979a is the MD5 sum of
an empty file compressed with `gzip --no-name`… This happened
because I forgot to update the config file after correcting the
module… sorry !
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Change name as suggested in pull request.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* New last/train module to train alignment parameters.
The last-train command creates a parameter file that
will be used by last/lastal module for sequence alignment.
It takes indexed sequences and query sequences as input
and we use the metadata of both to create an id of the
parameter output file.
Submission of the LAST modules is discussed in more
details in the issue #464. For consistancy, we use LAST
version 1219 for this whole development and will upgrade later.
* Corrected files according to the nf-core v1.14 standards.
* Fixed function.nf file for the last-train module.
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Find index name.
* Correct after the input channels were changed.
* Use double underscore as a name separator.
Single underscores can happen in ids, therefore, we would like to keep two underscores.
* Remove extra spaces.
* Fixed the passing of the "score matrix" line.
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Update software/last/train/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Running pytest with `--tag fastqc_single_end` does not work (it runs zero tests), as it appears that the tag name was changed to `fastqc` during the transition from underscores to slashes.
* added intervallisttools module
* add intervallisttools module
* arguments are now supplied using options.args
* removed java heapsize settings
* changes in main.nf and it is tested
* comment added
* Update software/gatk4/intervallisttools/meta.yml
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
* Update tests/software/gatk4/intervallisttools/test.yml
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
* review comment on tags in bedtointerval
* modified the test to get input from bedtointerval module
* Update software/gatk4/intervallisttools/meta.yml
* Apply suggestions from code review
Co-authored-by: Kevin Menden <kevin.menden@live.com>
* Apply suggestions from code review
* Update tests/config/pytest_software.yml
Co-authored-by: Kevin Menden <kevin.menden@live.com>
* Apply suggestions from code review
* Apply suggestions from code review
Co-authored-by: @praveenraj2018 <praveen.raj.somarajan@ki.se>
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
Co-authored-by: Kevin Menden <kevin.menden@live.com>
* output constant sites as a val as well as a file so it can be passed into iqtree
* Using an env variable because that's far safer!
* Update software/snpsites/main.nf
* remove hardcoded param that should be a user option
* Update software/snpsites/main.nf
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Bump pangolin version
* Add nextclade to software list
* Add nextclade module
* Update md5sum for Pangolin due to version bump
* Adding some URL to meta.yml
* Adding new line at end of file
Co-authored-by: JoseEspinosa <kadomu@gmail.com>
* New last/lastdb module to index sequences before alignment.
The `lastdb` command creates a sequence index for the LAST aligner
(https://gitlab.com/mcfrith/last). Input can be in FASTA or FASTQ
format, and compression is handled automagically. DNA or protein
sequences can be indexed.
The sequence index is a collection of files sharing the same basename.
This module sets the basename to the sample identifier (`$meta.id`) and
creates the index in a directory always called `lastdb`. The module's
output channel then conveys a copy of the metadata and the path to the
`lastdb` directory.
Other modules will follow (see Issue #464). The LAST aligner can align
proteins to proteins, DNA to DNA and can translate DNA align to
proteins.
* Remove trailing whitespace.
* Apply suggestions from code review
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Update as suggested in PR.
* Attempt to pass linting.
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
* Update README to include some git best practices
* correct linting errors
* extra info about returning to master and deleting the branch
* use rebase
* stress importance of rebase
* Update README to include some git best practices
* correct linting errors
* extra info about returning to master and deleting the branch
* Changed position of git commands
* move later git commands down the action list
