millironx/nf-core_modules
1
0
Fork 0
mirror of https://github.com/MillironX/nf-core_modules.git synced 2024-12-22 19:18:17 +00:00
Code Issues Releases Packages Activity
nf-core_modules/.github/PULL_REQUEST_TEMPLATE.md
MaxUlysse ebb6d5de1f fix: Apply suggestions from code review
2021-02-17 00:34:55 +01:00

1.5 KiB
Raw Blame History

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the <SOFTWARE>.version.txt file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --wt 2 --keep-workflow-wd
    • PROFILE=singularity pytest --tag <MODULE> --symlink --wt 2 --keep-workflow-wd
    • PROFILE=conda pytest --tag <MODULE> --symlink --wt 2 --keep-workflow-wd