millironx/nf-core_modules
1
0
Fork 0
mirror of https://github.com/MillironX/nf-core_modules.git synced 2024-11-10 20:23:10 +00:00
Code Issues Releases Packages Activity
nf-core_modules/.github/CONTRIBUTING.md
Maxime Garcia 75d1483417
Apply suggestions from code review 
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
2021-02-17 00:32:06 +01:00

2.8 KiB
Raw Blame History

nf-core/modules: Contributing Guidelines

Hi there! Many thanks for taking an interest in improving nf-core/modules.

We try to manage the required tasks for nf-core/modules using GitHub issues, you probably came to this page when creating one. Please use the pre-filled template to save time.

However, don't be put off by this template - other more general issues and suggestions are welcome! Contributions to the code are even more welcome ;)

If you need help using or modifying nf-core/modules then the best place to ask is on the nf-core Slack #modules channel (join our Slack here).

Contribution workflow

If you'd like to write some code for nf-core/modules, the standard workflow is as follows:

  1. Check that there isn't already an issue about your idea in the nf-core/modules issues to avoid duplicating work
    • If there isn't one already, please create one so that others know you're working on this
  2. Fork the nf-core/modules repository to your GitHub account
  3. When adding a module file, follow the guidelines
  4. Ensure that tests are working locally
  5. Submit a Pull Request against the master branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some docs from GitHub or even their excellent git resources.

Tests

When you create a pull request with changes, GitHub Actions will run automatic tests. Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.

Module tests

Each nf-core/module should be set up with a minimal set of test-data. GitHub Actions then runs the module on this data to ensure that it exits successfully. If there are any failures then the automated tests fail. These tests are run both with the latest available version of Nextflow and also the minimum required version that is stated in the pipeline code.

Getting help

For further information/help, please consult the nf-core/modules README and don't hesitate to get in touch on the nf-core Slack #modules channel (join our Slack here).

Images and figures

For overview images and other documents we follow the nf-core style guidelines and examples.